[ https://issues.apache.org/jira/browse/LUCENE-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Nistor updated LUCENE-5040: ---------------------------------- Attachment: patch.diff > wasted work in Lucene40TermVectorsWriter.finishTerm() > ----------------------------------------------------- > > Key: LUCENE-5040 > URL: https://issues.apache.org/jira/browse/LUCENE-5040 > Project: Lucene - Core > Issue Type: Bug > Components: core/codecs > Affects Versions: 4.3 > Environment: any > Reporter: Adrian Nistor > Priority: Minor > Labels: patch, perfomance > Attachments: patch.diff > > > The problem appears in version 4.3.0 and in revision 1490286. I > attached a two-line patch that fixes it. > In method "Lucene40TermVectorsWriter.finishTerm", the loop over > "offsetStartBuffer" should not be executed when "offsets" is "false". > When "offsets" is "false" the loop produces no results. The patch > just flips the order of the "if" and "for" statements. > Method "collect" in class "MultiComparatorNonScoringCollector" has a > similar loop (the last loop in the method over "comparators"), and > this loop is not executed when "queueFull" is false, just like in the > proposed patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org