Adrian Nistor created SOLR-4913:
-----------------------------------
Summary: Wasted work in PolyFieldTest.testSchemaBasics()
Key: SOLR-4913
URL: https://issues.apache.org/jira/browse/SOLR-4913
Project: Solr
Issue Type: Bug
Affects Versions: 4.3
Environment: any
Reporter: Adrian Nistor
Priority: Minor
Attachments: patch2.diff, patch3.diff, patch4.diff, patchAll.diff,
patch.diff
The problem appears in version 4.3.0 and in revision 1491451. I
attached a one-line patch (patch.diff) that fixes it. This problem
and the attached patch are similar to the previously fixed
LUCENE-5040, LUCENE-5041, and LUCENE-5044, and their patches.
In method "PolyFieldTest.testSchemaBasics", the loop over "dynFields"
should break immediately after "seen" is set to "true". All the
iterations after "seen" is set to "true" do not perform any useful
work, at best they just set "seen" again to "true".
Similar problems exist in "MoreLikeThisHandler.handleRequestBody",
"AbstractCurrencyFieldTest.testCurrencySchema", and
"BasicDistributedZk2Test.addNewReplica". I attached patches
patch2.diff, patch3.diff, and patch4.diff for these methods. I also
attached a patch (patchAll.diff) that aggregates all these changes in
one single patch.
Method "loadDataConfig" in class "DataImporter" has a similar loop
(over "config.getEntities()"), and this loop breaks immediately after
"isDeltaImportSupported" is set to "true", just like in the proposed
patches. Other methods (e.g., "IndexSchema.registerCopyField"
"OverseerCollectionProcessor.checkForAlias", "HttpSolrServer.request")
also have similar loops with similar breaks, just like in the proposed
patches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
