[ 
https://issues.apache.org/jira/browse/LUCENE-5038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679682#comment-13679682
 ] 

Simon Willnauer commented on LUCENE-5038:
-----------------------------------------

The reasoning here is that if I put in flush into the name it implies that this 
decision is done at flush time but it might be in the future that we make the 
decision earlier ie. before the first doc is added so we can write into the CFS 
directly.  I don't want this implying API here so I have chosen a different 
name. I agree DW is an impl detail and naming is hard :) what about 
_NewSegmentsUseCompoundFile_? 
                
> Don't call MergePolicy / IndexWriter during DWPT Flush
> ------------------------------------------------------
>
>                 Key: LUCENE-5038
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5038
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.3
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.4
>
>         Attachments: LUCENE-5038.patch, LUCENE-5038.patch, LUCENE-5038.patch
>
>
> We currently consult the indexwriter -> merge policy to decide if we need to 
> write CFS or not which is bad in many ways.
> - we should call mergepolicy only during merges
> - we should never sync on IW during DWPT flush
> - we should be able to make the decision if we need to write CFS or not 
> before flush, ie. we could write parts of the flush directly to CFS or even 
> start writing stored fields directly.
> - in the NRT case it might make sense to write all flushes to CFS to minimize 
> filedescriptors independent of the index size.
> I wonder if we can use a simple boolean for this in the IWC and get away with 
> not consulting merge policy. This would simplify concurrency a lot here 
> already.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to