[ 
https://issues.apache.org/jira/browse/SOLR-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682283#comment-13682283
 ] 

Robert Muir commented on SOLR-4872:
-----------------------------------

{quote}
You're assuming that the resources in question are tied to a concrete Tokenizer 
instance – but if you use TokenizerFactories (which 99.999% of solr users do) 
then you're going to get a shiny new Tokenizer instance for every Reader – 
hence my point that it seems like you really want the factory to be caching the 
data, and then cleaning it up when the factory is closed. 
{quote}

You don't know what you are talking about. Please dont accuse me of assuming 
anything.

*ALL* Tokenizers are created once per-thread per-field and reused across 
multiple readers.

Thanks
                
> Allow schema analysis object factories to be cleaned up properly when the 
> core shuts down
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-4872
>                 URL: https://issues.apache.org/jira/browse/SOLR-4872
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.3
>            Reporter: Benson Margulies
>         Attachments: solr-4872.patch
>
>
> I have a need, in an TokenizerFactory or TokenFilterFactory, to have a shared 
> cache that is cleaned up when the core is torn down. 
> There is no 'close' protocol on these things, and Solr rejects analysis 
> components that are SolrCoreAware. 
> Possible solutions:
> # add a close protocol to these factories and make sure it gets called at 
> core shutdown.
> # allow these items to be 'core-aware'.
> # invent some notion of 'schema-lifecycle-aware'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to