[
https://issues.apache.org/jira/browse/SOLR-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683219#comment-13683219
]
Andrzej Bialecki commented on SOLR-4916:
-----------------------------------------
Mark, this functionality looks very cool!
Re. Hadoop dependencies: the patch adds a hard dependency on Hadoop and its
dependencies directly to Solr core. I wonder if it's possible to refactor it so
that it could be optional and the functionality itself moved to contrib/ - this
way only users who want to use HdfsDirectory would need Hadoop deps.
Re. Cache and BlockCache implementation - I did something similar in Luke's
FsDirectory, where I decided to use Ehcache, although that implementation was
read-only so it was much simpler. Performance improvements for repeated
searches were of course dramatic, not so much for unique queries though. Do you
have some preliminary benchmarks for this implementation, how much slower is
the indexing / searching? Anyway, doing an Ehcache-based implementation of
Cache with your patch seems straightforward, too.
There's very little javadoc / package docs for the new public classes and
packages.
What are HdfsDirectory.LF_EXT and getNormalNames() for?
> Add support to write and read Solr index files and transaction log files to
> and from HDFS.
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-4916
> URL: https://issues.apache.org/jira/browse/SOLR-4916
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-4916.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
