[
https://issues.apache.org/jira/browse/LUCENE-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685469#comment-13685469
]
Michael McCandless commented on LUCENE-5030:
--------------------------------------------
Hmm POS_SEP and HOLE are still eating into Unicode's space (the last 2
code points)? Maybe, we should just use Integer.MAX_VALUE and
MAX_VALUE-1?
In fact I think you'll need to make POS_SEP and HOLE consistent across
both of the TS2A classes. I think you should just define them in
TokenStreamToAutomaton.java, and then reference those constants from
TokenStreamToUnicodeAutomaton.java?
There's a lot of whitespace noise here ... can you remove those
changes so we can more easily see the "real" changes? Thanks.
The preserveSep option means when finding a match we must "respect"
the boundaries between tokens. It could be you're seeing tests fail
because POS_SEP was different between the two classes?
> FuzzySuggester has to operate FSTs of Unicode-letters, not UTF-8, to work
> correctly for 1-byte (like English) and multi-byte (non-Latin) letters
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5030
> URL: https://issues.apache.org/jira/browse/LUCENE-5030
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.3
> Reporter: Artem Lukanin
> Attachments: nonlatin_fuzzySuggester1.patch,
> nonlatin_fuzzySuggester.patch
>
>
> There is a limitation in the current FuzzySuggester implementation: it
> computes edits in UTF-8 space instead of Unicode character (code point)
> space.
> This should be fixable: we'd need to fix TokenStreamToAutomaton to work in
> Unicode character space, then fix FuzzySuggester to do the same steps that
> FuzzyQuery does: do the LevN expansion in Unicode character space, then
> convert that automaton to UTF-8, then intersect with the suggest FST.
> See the discussion here:
> http://lucene.472066.n3.nabble.com/minFuzzyLength-in-FuzzySuggester-behaves-differently-for-English-and-Russian-td4067018.html#none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
