[ 
https://issues.apache.org/jira/browse/SOLR-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685829#comment-13685829
 ] 

Commit Tag Bot commented on SOLR-4931:
--------------------------------------

[branch_4x commit] shalin
http://svn.apache.org/viewvc?view=revision&revision=1493872

SOLR-4931: SolrDeletionPolicy onInit and onCommit methods changed to override 
exact signatures (with generics) from IndexDeletionPolicy
                
> Override exact signatures (with generics) in SolrDeletionPolicy
> ---------------------------------------------------------------
>
>                 Key: SOLR-4931
>                 URL: https://issues.apache.org/jira/browse/SOLR-4931
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 4.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 4.4
>
>         Attachments: SOLR-4931.patch, SOLR-4931.patch
>
>
> LUCENE-4876 changed the IndexDeletionPolicy to an abstract class. The 
> SolrDeletionPolicy extends this class but overrides the onInit and onCommit 
> methods with non generic parameters. This makes people who extend 
> SolrDeletionPolicy (even though we don't recommend doing that) run into a 
> Java6 bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6775192
> The workaround is to use reflection to call the parent class's method.  I 
> propose  that we change SolrDeletionPolicy to override parent's methods with 
> the exact signature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to