[ 
https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686519#comment-13686519
 ] 

Vadim Kirilchuk commented on SOLR-3076:
---------------------------------------

Yonik, it's great!

Just keep in mind several improvements:
* make _childDocuments inside SolrInputDocument lazy instead of new ArrayList() 
in constructor.
* at JavaBinCodec there is no need in SOLRINPUTDOC_CHILDS tag, it is easier to 
write "SOLRINPITDOC docFieldsSize childrenNum" instead of "SOLRINPUTDOC 
docFieldsSize SOLRINPUTDOC_CHILDS childrenNum"

There is also a blueprint of dih support for this: 
https://issues.apache.org/jira/secure/attachment/12576960/dih-3076.patch 
Maybe it will be better to move it to it's own jira ticket.

There are no support for:
* delete block
* overwrite/update block
* JSON

I hope it helps.



                
> Solr(Cloud) should support block joins
> --------------------------------------
>
>                 Key: SOLR-3076
>                 URL: https://issues.apache.org/jira/browse/SOLR-3076
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Grant Ingersoll
>            Assignee: Yonik Seeley
>             Fix For: 5.0, 4.4
>
>         Attachments: 27M-singlesegment-histogram.png, 27M-singlesegment.png, 
> bjq-vs-filters-backward-disi.patch, bjq-vs-filters-illegal-state.patch, 
> child-bjqparser.patch, dih-3076.patch, dih-config.xml, 
> parent-bjq-qparser.patch, parent-bjq-qparser.patch, Screen Shot 2012-07-17 at 
> 1.12.11 AM.png, SOLR-3076-childDocs.patch, SOLR-3076.patch, SOLR-3076.patch, 
> SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, 
> SOLR-3076.patch, SOLR-3076.patch, 
> SOLR-7036-childDocs-solr-fork-trunk-patched, 
> solrconf-bjq-erschema-snippet.xml, solrconfig.xml.patch, 
> tochild-bjq-filtered-search-fix.patch
>
>
> Lucene has the ability to do block joins, we should add it to Solr.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to