[ 
https://issues.apache.org/jira/browse/LUCENE-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686622#comment-13686622
 ] 

Adrien Grand commented on LUCENE-5063:
--------------------------------------

bq. i see, so we only need negatives in growablewriter for the case where we'd 
use 64 bpv for longs anyway.

Exactly. Negative values in a GrowableWriter are more 64-bits unsigned values 
than actual negative values.

bq. Or, maybe FC should only have a 'long' API to better match DV?

Are you talking about removing all get(Bytes|Shorts|Ints|Floats|Doubles) and 
only have getLongs which would return a NumericDocValues instance? Indeed I 
think it would make things simpler and more consistent (eg. comparators and 
FieldCacheRangeFilter) but this looks like a big change!

bq. This is consistent with SortedDocValuesImpl, except SortedDocValuesImpl has 
a 'startBPV' of 1, whereas its 4 here. Maybe we should use 1 here too?

Agreed.
                
> Allow GrowableWriter to store negative values
> ---------------------------------------------
>
>                 Key: LUCENE-5063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5063
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>             Fix For: 4.4
>
>         Attachments: LUCENE-5063.patch
>
>
> For some use-cases, it would be convenient to be able to store negative 
> values in a GrowableWriter, for example to use it in FieldCache: The first 
> term is the minimum value and one could use a GrowableWriter to store deltas 
> between this minimum value and the current value. (The need for negative 
> values comes from the fact that maxValue - minValue might be larger than 
> Long.MAX_VALUE.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to