[ 
https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686876#comment-13686876
 ] 

Erick Erickson commented on SOLR-4935:
--------------------------------------

bq: What exactly happens if you don't include instanceDir

it defaults to the name of the core, pretty much as you'd expect. For instance 
if I specify name=eoe, the instance dir is eoe/, relative to solr home.

The problem is that the core loading isn't smart enough to do the same default 
behavior if the instanceDir isn't specified in the <core> tag. One could easily 
argue that it _should_ be assuming the name is specified, but I'm not all that 
interested in changing functionality there and dealing with other places such a 
change might affect things when it's all going away...

But good point, I'll add a test with the following steps
1> create 2 cores
2> check persistence is good
3> swap one of the new cores with another core
4> insure persistence is good
5> rename the other core
6> insure that persistence is good

It's _probably_ OK, but there's no test that I know of that actually tries this 
kind of stuff...




                
> persisting solr.xml preserves extraneous values like "wt=json" in <core> tags 
> when creating cores via the admin handler
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4935
>                 URL: https://issues.apache.org/jira/browse/SOLR-4935
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.0, 4.4
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-4935.patch, SOLR-4935.patch
>
>
> I'll be soooo happy when we stop supporting persistence.
> Two problems
> 1> if instanceDir is not specified on the create, it's not persisted. And 
> subsequent starts of Solr will fail.
> 2> extraneous params are specified, made worse by SolrJ adding some stuff on 
> the create request like wt=javabin etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to