[ 
https://issues.apache.org/jira/browse/SOLR-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-4941:
---------------------------

    Attachment: infostream.txt
                SOLR-4941.patch

Patch that improves the tests and updates the logic added in SOLR-4934 so that 
if there is explicit useCompoundFile configuration as an init arg for a (known) 
MergePolicy we pass that to the IndexWriterConfig's setUseCompoundFile method 
and log a warning instead of just ignoring it.

patch also removes the warnings about the simple legacy <useCompoundFile> 
syntax since that actually makes sense now that it's a setting on IWC.

I've also updated the tests to inspect the useCompoundFile on the IWC as well 
as checking the results of adding some segments.

there is still a failure in testTieredMergePolicyConfig where (as i understand 
it from talking to mike on IRC) the merged segment after the optimize command 
should *not* be in CFS format because of the noCFSRatio setting -- but the 
merged segment is still in CFS. i've attached the infostream log from running 
"ant test -Dtestcase=TestMergePolicyConfig 
-Dtests.method=testTieredMergePolicyConfig" to see if it helps illuminate the 
problem ... i suspect it's either a test bug because i still missunderstand 
something about how the MergePolicy settings come into play, or a genuine bug 
in the lower level TieredMP code -- i don't see how it could be specific to the 
solr config parsing logic since the IWC and TMP getters say they got the 
expected settings.

(NOTE: the patch includes a nocommit in solrconfig-mergepolicy.xml to turn off 
the infostream before committing)
                
> useCompoundFile default has changed, simple config option no longer seems to 
> work
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-4941
>                 URL: https://issues.apache.org/jira/browse/SOLR-4941
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: infostream.txt, SOLR-4941.patch
>
>
> Spin off of SOLR-4934.  We should updated tests to ensure that the various 
> ways of specifying useCompoundFile as well as the expected default are 
> working properly after LUCENE-5038

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to