[
https://issues.apache.org/jira/browse/LUCENE-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691488#comment-13691488
]
Martijn van Groningen commented on LUCENE-5065:
-----------------------------------------------
+1! This test has really become unreadable / unmaintainable.
I would split it into separate test classes each testing a specific part:
* A test that both tests the first and second pass collector.
* Some as above but then a sharded test.
* Move the test for the all groups collector to AllGroupsCollectorTest.
* Move out the block grouping to a dedicated test.
* I think the usage of CacheCollector can be removed and perhaps this can just
be tested via the 'GroupingSearchTest' class.
This is a big tasks :-) So it would be a more digestible task if this is done
step by step.
> Refactor TestGrouping.java to break TestRandom into separate tests
> ------------------------------------------------------------------
>
> Key: LUCENE-5065
> URL: https://issues.apache.org/jira/browse/LUCENE-5065
> Project: Lucene - Core
> Issue Type: Test
> Components: modules/grouping
> Affects Versions: 4.3.1
> Reporter: Tom Burton-West
> Priority: Minor
>
> lucene/grouping/src/test/org/apache/lucene/search/grouping
> TestGrouping.java combines multiple tests inside of one test: TestRandom().
> This makes it difficult to understand or for new users to use the
> TestGrouping.java as an entry to understanding grouping functionality.
> Either break TestRandom into separate tests or add small separate tests for
> the most important parts of TestRandom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
