[ 
https://issues.apache.org/jira/browse/SOLR-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693510#comment-13693510
 ] 

Mark Miller commented on SOLR-4943:
-----------------------------------

bq. there being "special" paths that the user can't change in configuration – 
i'd just really like to avoid adding any more 

I much prefer this - being able to count on these types of urls is very useful! 
I hate that the core admin handler url is configurable and in fact it breaks 
solrcloud if you configure it.

bq. CoreAdminHandler's STATUS call seemed like a good place to return

Personally, I don't like the idea of jamming these into the status call. I 
think they have a good structure now - they just should not be at the core 
level, but at the system level.

bq. because of the "is CoreContainer null? is SolrCore null?" situation) and 
seems overly complicated 

I think it's fairly simple atm - if it's bothersome, I'd prefer we just remove 
them at the core level for 5.0 rather than try and refactor it to be very 
slightly simpler code. 

bq. either way, we need some tests 

Yes of course we need tests.

bq. why is there a change to SolrIndexSearcher in this patch?

It's just an unrelated thing that got caught up in the patch.
                
> Add a new info admin handler.
> -----------------------------
>
>                 Key: SOLR-4943
>                 URL: https://issues.apache.org/jira/browse/SOLR-4943
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4943-2.patch, SOLR-4943-3.patch, SOLR-4943.patch
>
>
> Currently, you have to specify a core to get system information for a variety 
> of request handlers - properties, logging, thread dump, system, etc.
> These should be available at a system location and not core specific location.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to