[ https://issues.apache.org/jira/browse/LUCENE-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artem Lukanin updated LUCENE-5030: ---------------------------------- Attachment: nonlatin_fuzzySuggester_combo2.patch I have restored testStolenBytes completely and now all the tests pass. But I'm not sure, what did you mean by 0xff byte in {code}token(new BytesRef(new byte[] {0x61, (byte) 0xff, 0x61})){code}? Letter ÿ or SEP_LABEL? Now it is treated as letter ÿ, but in the previous modification of the test I treated it as SEP_LABEL. > FuzzySuggester has to operate FSTs of Unicode-letters, not UTF-8, to work > correctly for 1-byte (like English) and multi-byte (non-Latin) letters > ------------------------------------------------------------------------------------------------------------------------------------------------ > > Key: LUCENE-5030 > URL: https://issues.apache.org/jira/browse/LUCENE-5030 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 4.3 > Reporter: Artem Lukanin > Attachments: benchmark-INFO_SEP.txt, benchmark-old.txt, > benchmark-wo_convertion.txt, nonlatin_fuzzySuggester1.patch, > nonlatin_fuzzySuggester2.patch, nonlatin_fuzzySuggester3.patch, > nonlatin_fuzzySuggester4.patch, nonlatin_fuzzySuggester_combo1.patch, > nonlatin_fuzzySuggester_combo2.patch, nonlatin_fuzzySuggester_combo.patch, > nonlatin_fuzzySuggester.patch, nonlatin_fuzzySuggester.patch, > nonlatin_fuzzySuggester.patch, run-suggest-benchmark.patch > > > There is a limitation in the current FuzzySuggester implementation: it > computes edits in UTF-8 space instead of Unicode character (code point) > space. > This should be fixable: we'd need to fix TokenStreamToAutomaton to work in > Unicode character space, then fix FuzzySuggester to do the same steps that > FuzzyQuery does: do the LevN expansion in Unicode character space, then > convert that automaton to UTF-8, then intersect with the suggest FST. > See the discussion here: > http://lucene.472066.n3.nabble.com/minFuzzyLength-in-FuzzySuggester-behaves-differently-for-English-and-Russian-td4067018.html#none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org