[ 
https://issues.apache.org/jira/browse/SOLR-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694055#comment-13694055
 ] 

Yonik Seeley edited comment on SOLR-4926 at 6/26/13 5:33 PM:
-------------------------------------------------------------

bq. I have this competing approach attached 

Yeah, I like the rollback right before... safer in the event that somehow the 
IW acquires more changes.  I was initially worried about code that uses the IW 
to reopen the reader, but that code (openSearcher) doesn't force open a writer 
and has a fallback to reopen on the reader.

I'll start looping the chaos test with your patch and see how it goes.
edit: 20 passes so far... commit it!
                
      was (Author: [email protected]):
    bq. I have this competing approach attached 

Yeah, I like the rollback right before... safer in the event that somehow the 
IW acquires more changes.  I was initially worried about code that uses the IW 
to reopen the reader, but that code (openSearcher) doesn't force open a writer 
and has a fallback to reopen on the reader.

I'll start looping the chaos test with your patch and see how it goes.
                  
> I am seeing RecoveryZkTest and ChaosMonkeySafeLeaderTest fail often on trunk.
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-4926
>                 URL: https://issues.apache.org/jira/browse/SOLR-4926
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Blocker
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-4926.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to