[
https://issues.apache.org/jira/browse/SOLR-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-4943:
---------------------------
Attachment: SOLR-4943-3__hoss_variant.patch
bq. I much prefer this ...
I know, agree to disagree
bq. I think it's fairly simple atm
Complex probably wasn't the right word .. the code is simple, but it left the
door open very side for someone to introduce bugs in the future for one code
path or the other.
Take a look at this SOLR-4943-3__hoss_variant.patch i'm attaching -- to me this
is just as simple and easy to understand as what you had, but makes it a lot
harder for someone down the road to break it w/o getting an obvious compile
failure because the static methods limit what the code has access to (and if
they change the signature of hte static method, then they'll get a compile
error in InfoHandler and realize why the code is written the way it is.
bq. if it's bothersome, I'd prefer we just remove them at the core level for
5.0 rather than try and refactor it to be very slightly simpler code.
+1 ... starting with my SOLR-4943-3__hoss_variant.patch it would be trivial to
move those static methods into InfoHandler ... they could still be called from
the existing handlers, but those handlers would be marked deprecated.
> Add a new info admin handler.
> -----------------------------
>
> Key: SOLR-4943
> URL: https://issues.apache.org/jira/browse/SOLR-4943
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.0, 4.4
>
> Attachments: SOLR-4943-2.patch, SOLR-4943-3__hoss_variant.patch,
> SOLR-4943-3.patch, SOLR-4943.patch
>
>
> Currently, you have to specify a core to get system information for a variety
> of request handlers - properties, logging, thread dump, system, etc.
> These should be available at a system location and not core specific location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
