[
https://issues.apache.org/jira/browse/LUCENE-5080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-5080:
--------------------------------
Attachment: LUCENE-5080.patch
here's my patch. To address Shai's concern, i just combined the two setters
into one and didnt do any ctors (that would sorta be redundant with the
combined-setter, and i dont like the name reset).
Additionally i made the defaults public constants.
> CMS setters cannot work unless you setMaxMergeCount before you
> setMaxThreadCount
> --------------------------------------------------------------------------------
>
> Key: LUCENE-5080
> URL: https://issues.apache.org/jira/browse/LUCENE-5080
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5080.patch
>
>
> {code}
> public void setMaxThreadCount(int count) {
> ...
> if (count > maxMergeCount) {
> throw new IllegalArgumentException("count should be <= maxMergeCount (=
> " + maxMergeCount + ")");
> }
> {code}
> but:
> {code}
> public void setMaxMergeCount(int count) {
> ...
> if (count < maxThreadCount) {
> throw new IllegalArgumentException("count should be >= maxThreadCount
> (= " + maxThreadCount + ")");
> }
> {code}
> So you must call them in a magical order. I think we should nuke these
> setters and just have a CMS(int,int)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
