[
https://issues.apache.org/jira/browse/SOLR-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated SOLR-4948:
--------------------------------
Attachment: SOLR-4948.patch
Have been away for a week, now getting back round to this.
Test failures were all under SolrJ, largely related to the default static
initialization code that assumes we want a CoreContainer with a single core set
up. This patch should catch them all.
N.B., it turns out that actually running SolrJ tests is a good way to catch
these before committing. I had managed to just run everything under
solr-core...
> Tidy up CoreContainer construction logic
> ----------------------------------------
>
> Key: SOLR-4948
> URL: https://issues.apache.org/jira/browse/SOLR-4948
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch,
> SOLR-4948.patch, SOLR-4948.patch, SOLR-4948.patch
>
>
> While writing tests for SOLR-4914, I discovered that it's *really difficult*
> to create a CoreContainer. There are a bunch of constructors which
> initialise different things, one (but only one!) of which also loads all the
> cores. Then you have the Initializer object, which basically does the same
> thing. Sort of. And then the TestHarness doesn't actually use
> CoreContainer, but an anonymous subclass of CoreContainer which has it's own
> initialisation logic. It would be nice to clean this up!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
