[
https://issues.apache.org/jira/browse/SOLR-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699613#comment-13699613
]
Erik Hatcher commented on SOLR-4991:
------------------------------------
bq. Correctness cannot be guaranteed for custom impls because they might forget
to increment it.
Same with any subclasses of HighlightingPluginBase too.
bq. It works for handlers because RequestHandlerBase increments the counter.
But if we decide to go this way, we should change it to be an AtomicLong.
I just followed HighlightingPluginBase using a long.
But perhaps best to remove numRequests altogether here and just get the query
parsers showing up as plugins minus any stats.
> Register QParserPlugin's as SolrInfoMBean's, allowing them to be visible
> externally like other plugins
> ------------------------------------------------------------------------------------------------------
>
> Key: SOLR-4991
> URL: https://issues.apache.org/jira/browse/SOLR-4991
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
> Reporter: Erik Hatcher
> Fix For: 5.0, 4.4
>
> Attachments: SOLR-4991.patch, SOLR-4991.patch
>
>
> QParserPlugins currently cannot be seen externally as official plugins*.
> Let's register them as SolrInfoMBeans so they can be seen remotely.
> * Yes, solrconfig.xml itself could be retrieved and parsed, but many other
> similar plugins are available as MBeans and so should be query parsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
