[ 
https://issues.apache.org/jira/browse/LUCENE-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700317#comment-13700317
 ] 

Mark Miller commented on LUCENE-5093:
-------------------------------------

bq. I would prefer to have these checks in plain Ant or Ant-embedded Groovy 
logic.

I think it depends - unless we rewrite the whole smoke tester, I think it's 
better that this logic is in one place - the smoke tester script. Otherwise, 
over time, some checks might be added to the testNotice method of the smoke 
tester but not to the fast fail check in ant or groovy, and then it doesn't 
help much with fixing smoke tester fails. Any expansion of tests will have to 
be done in two places, in two non java languages (yuck and yuck).
                
> nightly-smoke should run some fail fast checks before doing the full smoke 
> tester
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-5093
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5093
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, 4.4
>
>         Attachments: LUCENE-5093.patch
>
>
> If something like the NOTICES fail the smoke tester, it currently takes 22 
> minutes to find out on my pretty fast machine. That means testing a fix also 
> takes 22 minutes.
> It would be nice if some of these types of checks happened right away on the 
> src tree - we should also check the actual artifacts with the same check 
> later - but also have this fail fast path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to