[ 
https://issues.apache.org/jira/browse/LUCENE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704893#comment-13704893
 ] 

Robert Muir commented on LUCENE-5081:
-------------------------------------

I looked thru it: thanks Adrien! +1

Perhaps it would be good to add a few extreme tests (like all bits empty/all 
set).
Should we implement hashcode/equals? The other impls (fixed/open/etc) have this.
In general we should maybe open a followup issue to give these docidset classes 
a base test superclass test.
TestOpenBitset and TestFixedBitset are almost complete duplicates of each other 
for example. Any stuff that
can test via docidset/iterator apis should probably do so, and other impl stuff 
like intersect() can stay
in each test (thats fine, at least we improve things).

                
> Compress doc ID sets
> --------------------
>
>                 Key: LUCENE-5081
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5081
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5081.patch, LUCENE-5081.patch
>
>
> Our filters use bit sets a lot to store document IDs. However, it is likely 
> that most of them are sparse hence easily compressible. Having efficient 
> compressed sets would allow for caching more data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to