[ 
https://issues.apache.org/jira/browse/LUCENE-5100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705738#comment-13705738
 ] 

Uwe Schindler commented on LUCENE-5100:
---------------------------------------

Patch looks good. I would also keep the non-DocIdSet testing separate: 
prevSetBit/nextSetBit/flip/... are not part of the main DocIdSet API, so they 
should not be in the base test case. But you can still use methods from the 
base class to check what happend after you did a flip(), so implementing a test 
for flip() should be easy.
                
> BaseDocIdSetTestCase
> --------------------
>
>                 Key: LUCENE-5100
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5100
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>         Attachments: LUCENE-5100.patch, LUCENE-5100.patch
>
>
> As Robert said on LUCENE-5081, we would benefit from having common testing 
> infrastructure for our DocIdSet implementations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to