[
https://issues.apache.org/jira/browse/SOLR-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Isaac Hebsh updated SOLR-5035:
------------------------------
Description:
Currently, all of the grouping work is coupled into the QueryComponent. It
seems that we can split the component into two different components, without
writing even one extra line of code.
Best example is, in method 'prepare' of the QueryComponent:
{code:java}
boolean grouping = params.getBool(GroupParams.GROUP, false);
if (!grouping) {
return;
}
{code}
(Obviously, I forgot to mention that after that code, there are dozens of
lines, which only relevant to grouping.)
This is clearly unnecessary coupling...
was:
Currently, all of the grouping work is coupled into the QueryComponent. It
seems that we can split the component into two different components, without
writing even one extra line of code.
Best example is, in method 'prepare' of the QueryComponent:
{code:java}
boolean grouping = params.getBool(GroupParams.GROUP, false);
if (!grouping) {
return;
}
{code}
This is clearly unnecessary coupling...
> decouple grouping functionality from the query component
> --------------------------------------------------------
>
> Key: SOLR-5035
> URL: https://issues.apache.org/jira/browse/SOLR-5035
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.3.1
> Reporter: Isaac Hebsh
>
> Currently, all of the grouping work is coupled into the QueryComponent. It
> seems that we can split the component into two different components, without
> writing even one extra line of code.
> Best example is, in method 'prepare' of the QueryComponent:
> {code:java}
> boolean grouping = params.getBool(GroupParams.GROUP, false);
> if (!grouping) {
> return;
> }
> {code}
> (Obviously, I forgot to mention that after that code, there are dozens of
> lines, which only relevant to grouping.)
> This is clearly unnecessary coupling...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
