[
https://issues.apache.org/jira/browse/LUCENE-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709944#comment-13709944
]
Robert Muir commented on LUCENE-5117:
-------------------------------------
After investigation there are a few concerns of mine:
* today, there are some uses of DISI not checking the result of iterator()
* changing the API here is kinda a "break" (maybe should be 5.0 only?)
* I am not totally happy with the change because of Weight.scorer can return a
null Scorer (which is a DISI). Although this is "unrelated" to DISI.iterator(),
its still a potential cause for bugs.
Maybe there is a better solution I'm not thinking of too...
> DISI.iterator() should never return null.
> -----------------------------------------
>
> Key: LUCENE-5117
> URL: https://issues.apache.org/jira/browse/LUCENE-5117
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> If you have a Filter, you have to check for null twice: Filter.getDocIDSet()
> can return a null DocIDSet, and then DocIDSet.iterator() can return a null
> iterator.
> There is no reason for this: I think iterator() should never return null
> (consistent with terms/postings apis).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
