[ 
https://issues.apache.org/jira/browse/SOLR-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-5037:
-----------------------------

    Attachment: SOLR-5037.patch

Erik, in your patch you asked:

{code:java}
   String[] fieldnames;
-  SchemaField[] fields;
+  String[] fields;    // still need to keep this?  or would 'fieldnames' be 
enough?
{code}

The attached patch, based on yours, removes the {{fields}} array, substituting 
the {{fieldnames}} array for it in most places, and switching to using null 
entries from the {{adders}} array to indicate which field(s) should be skipped.

All Solr tests pass.

+1 to get this in before the 4.4 respin.
                
> CSV Update Handler Needs to be updated for new field guessing
> -------------------------------------------------------------
>
>                 Key: SOLR-5037
>                 URL: https://issues.apache.org/jira/browse/SOLR-5037
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.3
>            Reporter: Grant Ingersoll
>            Priority: Minor
>             Fix For: 5.0, 4.4
>
>         Attachments: SOLR-5037.patch, SOLR-5037.patch
>
>
> The CSV Update handler throws an exception if a field doesn't exist.  Given 
> the new schemaless stuff, we probably shouldn't do this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to