[ 
https://issues.apache.org/jira/browse/LUCENE-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-5128:
-------------------------------

    Attachment: LUCENE-5128.patch

I had a chat w/ Mike about what's going on in the test and turns out the test 
is fine, comments needed some improvements. So I fixed IndexSearcher to throw 
IllegalArgEx if searchAfter.doc >= maxDoc + fixed test comments (I think they 
better explain what's going on there -- Mike, appreciate your review!) and set 
after.doc to maxDoc-1.

I think it's ready. This all makes sense now (to me). Core tests pass. I'd 
appreciate some review, but I intend to commit this tomorrow.
                
> Calling IndexSearcher.searchAfter beyond the number of stored documents 
> causes ArrayIndexOutOfBoundsException
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5128
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5128
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 4.2
>            Reporter: crocket
>         Attachments: LUCENE-5128.patch, LUCENE-5128.patch
>
>
> ArrayIndexOutOfBoundsException makes it harder to reason about the cause.
> Is there a better way to notify programmers of the cause?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to