[ 
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4876:
-------------------------------

    Attachment: LUCENE-4876.patch

All tests pass (including Lucene and Solr). I also resolved the nocommit by 
modifying the test. It tests rolling back the index, it shouldn't care about 
whether the IndexCommit being snapshotted is the exact same reference. Also, 
SDP seems to be working correctly by updating the IC reference. It makes no 
sense to use an old reference.

So now you cannot share IWC because of the SetOnce<IndexWriter). Users cannot 
make a mistake, yet simple apps don't need to do weird things to get a handle 
to the objects they set on IWC.

If there are no objections, I will commit it.
                
> IndexWriterConfig.clone should clone the MergeScheduler
> -------------------------------------------------------
>
>                 Key: LUCENE-4876
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4876
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 4.3
>
>         Attachments: LUCENE-4876.patch, LUCENE-4876.patch, LUCENE-4876.patch, 
> LUCENE-4876.patch, LUCENE-4876.patch
>
>
> ConcurrentMergeScheduler has a List<MergeThread> member to track the running 
> merging threads, so IndexWriterConfig.clone should clone the merge scheduler 
> so that both IndexWriterConfig instances are independant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to