[
https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722370#comment-13722370
]
Michael McCandless commented on LUCENE-4985:
--------------------------------------------
This is a nice cleanup!
It's still hard to mix all three kinds of facet requests? E.g. I
think it's realistic for an app to use SSDV for flat fields (less RAM
usage than taxo, important if there are lots of ords), range for
"volatile" numeric fields (e.g. time delta based), and taxo for
hierarchies.
It seems like we could have a FacetsAccumulator.create that took both
SSDVReaderState and TaxoReader and created the right
FacetsAccumulator ... and I guess we'd need a SSDVFacetRequest.
Or I guess I can just create the directly MultiFacetsAccumulator
myself ... FA.create is just sugar.
This all can wait for a follow-on issue ... these improvements are
already great.
Should we move MultiFacetsAccumulator somewhere else (out of .range
package)? It's more generic now?
bq. FacetsAccumulator.create documents that you may receive List<FacetResult>
in a different order than you passed in, guaranteeing that all
RangeFacetRequests come last.
Hmm, can we fix that? (So that the order of the results matches the
order of the requests).
bq. Modified DrillSideways to take either TaxonomyReader or
SortedSetDVReaderState because otherise it cannot be used with SortedSetDV
facets. Mike, can you please review it?
Those changes look good! I think we can now simplify
TestDrillSideways (previously it had to @Override
getDrillDown/SidewaysAccumulator to use sorted set)?
> Make it easier to mix different kinds of FacetRequests
> ------------------------------------------------------
>
> Key: LUCENE-4985
> URL: https://issues.apache.org/jira/browse/LUCENE-4985
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Michael McCandless
> Fix For: 5.0, 4.5
>
> Attachments: LUCENE-4985.patch, LUCENE-4985.patch
>
>
> Spinoff from LUCENE-4980, where we added a strange class called
> RangeFacetsAccumulatorWrapper, which takes an incoming FSP, splits out the
> FacetRequests into range and non-range, delegates to two accumulators for
> each set, and then zips the results back together in order.
> Somehow we should generalize this class and make it work with
> SortedSetDocValuesAccumulator as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
