[ 
https://issues.apache.org/jira/browse/LUCENE-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722770#comment-13722770
 ] 

Adrien Grand commented on LUCENE-5145:
--------------------------------------

Thanks Boaz, the patch looks very good!
 - I like the fact that the addition of the new bulk API helped make fillValues 
final!
 - OrdinalMap.subIndexes, SortedDocValuesWriter.pending and 
SortedSetDocValuesWriter.pending are 0-based so they could use the new 
{{AppendingPackedLongBuffer}} instead of {{AppendingDeltaPackedLongBuffer}}, 
can you update the patch?


                
> Added AppendingPackedLongBuffer & extended AbstractAppendingLongBuffer family 
> (customizable compression ratio + bulk retrieval)
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5145
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5145
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Boaz Leskes
>            Assignee: Adrien Grand
>         Attachments: LUCENE-5145.patch
>
>
> Made acceptableOverheadRatio configurable 
> Added bulk get to AbstractAppendingLongBuffer classes, for faster retrieval.
> Introduced a new variant, AppendingPackedLongBuffer which solely relies on 
> PackedInts as a back-end. This new class is useful where people have 
> non-negative numbers with a fairly uniform distribution over a fixed 
> (limited) range. Ex. facets ordinals.
> To distinguish it from AppendingPackedLongBuffer, delta based 
> AppendingLongBuffer was renamed to AppendingDeltaPackedLongBuffer
> Fixed an Issue with NullReader where it didn't respect it's valueCount in 
> bulk gets.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to