[ 
https://issues.apache.org/jira/browse/SOLR-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726739#comment-13726739
 ] 

Jack Krupansky commented on SOLR-5108:
--------------------------------------

Sounds like this might resolve SOLR-4304 - "NPE in Solr SpellCheckComponent if 
more than one QueryConverter".
                
> plugin loading should fail if mor then one instance of a singleton plugin is 
> found
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-5108
>                 URL: https://issues.apache.org/jira/browse/SOLR-5108
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>
> Continuing from the config parsing/validation work done in SOLR-4953, we 
> should improve SolrConfig so that parsing fails if multiple instances of a 
> "plugin" are found for types of plugins where only one is allowed to be used 
> at a time.
> at the moment, {{SolrConfig.loadPluginInfo}} happily initializes a 
> {{List<PluginInfo>}} for whatever xpath it's given, and then later code can 
> either call {{List<PluginInfo> getPluginInfos(String)}} or {{PluginInfo 
> getPluginInfo(String)}} (the later just being shorthand for getting the first 
> item in the list.
> we could make {{getPluginInfo(String)}} throw an error if the list has 
> multiple items, but i think we should also change the signature of 
> {{loadPluginInfo}} to be explicit about how many instances we expect to find, 
> so we can error earlier, and have a redundant check.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to