[
https://issues.apache.org/jira/browse/SOLR-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13729383#comment-13729383
]
Uwe Schindler commented on SOLR-5091:
-------------------------------------
Hi Grant,
one important question: Robert and I did a lot of work on making the parsing of
URL query parameters unicode conform and prevent the possibly corrumpt servlet
container from jumping in. I hope your changes don't disable the Solr's own URL
parser in SolrRequestParsers! Otherwise we are back at broken Tomcat ISO-8859-1
parsing or Jetty's crazy and slow Readers. SolrRequestParsers now also supports
non-UTF-8 REST parameters via the {{&ie=encoding}} request parameter in the URL.
I just want to make sure that the parsing of HTTP requests and filling
SolrQuery's parameter maps is still done by SolrRequestParsers!
> Clean up Servlets APIs, Kill SolrDispatchFilter, simplify API creation
> ----------------------------------------------------------------------
>
> Key: SOLR-5091
> URL: https://issues.apache.org/jira/browse/SOLR-5091
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Fix For: 5.0
>
> Attachments: SOLR-5091.patch
>
>
> This is an issue to track a series of sub issues related to deprecated and
> crufty Servlet/REST API code. I'll create sub-tasks to manage them.
> # Clean up all the old UI stuff (old redirects)
> # Kill/Simplify SolrDispatchFilter -- for instance, why not make the user
> always have a core name in 5.0? i.e. /collection1 is the default core
> ## I'd like to move to just using Guice's servlet extension to do this,
> which, I think will also make it easier to run Solr in other containers (i.e.
> non-servlet environments) due to the fact that you don't have to tie the
> request handling logic specifically to a Servlet.
> # Simplify the creation and testing of REST and other APIs via Guice +
> Restlet, which I've done on a number of occasions.
> ## It might be also possible to move all of the APIs onto Restlet and
> maintain back compat through a simple restlet proxy (still exploring this).
> This would also have the benefit of abstracting the core request processing
> out of the Servlet context and make that an implementation detail.
> ## Moving to Guice, IMO, will make it easier to isolate and test individual
> components by being able to inject mocks easier.
> I am close to a working patch for some of this. I will post incremental
> updates/issues as I move forward on this, but I think we should take 5.x as
> an opportunity to be more agnostic of container and I believe the approach I
> have in mind will do so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
