[ https://issues.apache.org/jira/browse/LUCENE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13729640#comment-13729640 ]
Adrien Grand commented on LUCENE-5157: -------------------------------------- I like the getSegmentOrd change. Regarding the naming, I'm undecided but I think it's nice to use segment even if it is less generic, so that we don't have to use another word such as "index" to identify the TermsEnum, which could be confusing with "ord"? > Refactoring MultiDocValues.OrdinalMap to clarify API and internal structure. > ---------------------------------------------------------------------------- > > Key: LUCENE-5157 > URL: https://issues.apache.org/jira/browse/LUCENE-5157 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Boaz Leskes > Priority: Minor > Attachments: LUCENE-5157.patch > > > I refactored MultiDocValues.OrdinalMap, removing one unused parameter and > renaming some methods to more clearly communicate what they do. Also I > renamed subIndex references to segmentIndex. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org