Not really. If typos are going to require issues... I’ll refrain from reporting them. (How many typo Jiras have you ever seen? Is there even a category for that?)
I’ll certainly file issues for bugs and features, but for typos? No. If a committer sees a typo, are they required to file an issue to fix it? Oh... yeah... right... they don’t usually correct typos. Oh well. So, ... never mind. -- Jack Krupansky From: Stefan Matheis Sent: Saturday, August 10, 2013 8:13 AM To: [email protected] Subject: Re: Copy-paste typo in org.apache.solr.highlight.DefaultSolrHighlighter#init Jack, don't get me wrong, but wouldn't it be easier if you'd open an issue and attach a patch, if you already know where & what needs to be changed? - Stefan On Saturday, August 10, 2013 at 2:48 AM, Jack Krupansky wrote: A copy paste typo in org.apache.solr.highlight.DefaultSolrHighlighter#init: // Load the formatters SolrFormatter fmt = solrCore.initPlugins(info.getChildren("formatter"), formatters,SolrFormatter.class,null); if (fmt == null) fmt = new HtmlFormatter(); formatters.put("", fmt); formatters.put(null, fmt); // Load the formatters SolrEncoder enc = solrCore.initPlugins(info.getChildren("encoder"), encoders,SolrEncoder.class,null); if (enc == null) enc = new DefaultEncoder(); encoders.put("", enc); encoders.put(null, enc); The second comment should be “// Load the encoders”. -- Jack Krupansky
