[ 
https://issues.apache.org/jira/browse/SOLR-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736014#comment-13736014
 ] 

Uwe Schindler commented on SOLR-5134:
-------------------------------------

Hi Mark,
I think for saefty the close() method in the HdfsIndexOutput should be 
implemented like the one of FSIndexOutput in my recent patch on LUCENE-5164:
It should use IOUtils.closeWhileHandlingException with the possible IOException 
of super.close(). Otherwise it might happen that the output is not fully closed 
if an error on writing the final buffer happens.
                
> Have HdfsIndexOutput extend BufferedIndexOutput
> -----------------------------------------------
>
>                 Key: SOLR-5134
>                 URL: https://issues.apache.org/jira/browse/SOLR-5134
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.4
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-5134.patch
>
>
> Upstream Blur has moved HdfsIndexOutput to use BufferedIndexOutput and the 
> simple FS IndexOutput does as well - seems we should do the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to