[ https://issues.apache.org/jira/browse/LUCENE-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736294#comment-13736294 ]
ASF subversion and git services commented on LUCENE-5164: --------------------------------------------------------- Commit 1512949 from [~thetaphi] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1512949 ] Merged revision(s) 1512937 from lucene/dev/trunk: LUCENE-5164: Fix default chunk sizes in FSDirectory to not be unnecessarily large (now 8192 bytes); also use chunking when writing to index files. FSDirectory#setReadChunkSize() is now deprecated and will be removed in Lucene 5.0 > Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory > --------------------------------------------------------------- > > Key: LUCENE-5164 > URL: https://issues.apache.org/jira/browse/LUCENE-5164 > Project: Lucene - Core > Issue Type: Bug > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Attachments: LUCENE-5164-4x.patch, LUCENE-5164.patch, > LUCENE-5164.patch, LUCENE-5164.patch, LUCENE-5164.patch, LUCENE-5164.patch > > > Followup from LUCENE-5161: > In former times we added the OOM cactching in NIOFSDir and SimpleFSDir > because nobody understand why the OOM could happen on FileChannel.read() or > SimpleFSDir.read(). By reading the Java code its easy to understand (it > allocates direct buffers with same size as the requested length to read). As > we have chunking now reduce to a few kilobytes it cannot happen anymore that > we get spurious OOMs. > In fact we might hide a *real* OOM! So we should remove it. > I am also not sure if we should make chunk size configureable in FSDirectory > at all! It makes no sense to me (it was in fact only added for people that > hit the OOM to fine-tune). > In my opinion we should remove the setter in trunk and keep it deprecated in > 4.x. The buf size is then in trunk equal to the defaults from LUCENE-5161. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org