[
https://issues.apache.org/jira/browse/LUCENE-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738120#comment-13738120
]
Robert Muir commented on LUCENE-5170:
-------------------------------------
{quote}
I would suggest to make it mandatory in Lucene trunk, and add the missing ctor
in Lucene 4.x, too. The default one should be deprecated with a hint that it
might be a bad idea to use this default.
{quote}
Yes, this is exactly what i think we should do. i really should be a mandatory
parameter today (but cannot really work without also having the getter
available!)
> Add getter for reuse strategy to Analyzer, make AnalyzerWrapper's reuse
> strategy configureable
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-5170
> URL: https://issues.apache.org/jira/browse/LUCENE-5170
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other, modules/analysis
> Affects Versions: 4.4
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.0, 4.5
>
> Attachments: LUCENE-5170.patch
>
>
> If you write an Analyzer that wraps another one (but without using
> AnalyzerWrapper) you may need use the same reuse strategy in your wrapper.
> This is not possible as there is no way to get the reuse startegy (private
> field and no getter).
> An example is ES's NamedAnalyzer, see my comment:
> [https://github.com/elasticsearch/elasticsearch/commit/b9a2fbd8741aa1b9beffb7d2922fc9b4525397e4#src/main/java/org/elasticsearch/index/analysis/NamedAnalyzer.java]
> This would add a getter, just a 3-liner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
