[
https://issues.apache.org/jira/browse/LUCENE-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738263#comment-13738263
]
Uwe Schindler commented on LUCENE-5173:
---------------------------------------
Patch is fine. I like that the checkindex allows older segments with empty
size, but once a segment was merged it can no longer be empty.
Maybe the assert in SegmentMerge should be a hard check, unless SegmentMerger
always strictly throws away empty segments (not that somebody can somehow with
a crazy alcoholic mergepolicy create those segments again).
> Add checkindex piece of LUCENE-5116
> -----------------------------------
>
> Key: LUCENE-5173
> URL: https://issues.apache.org/jira/browse/LUCENE-5173
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: LUCENE-5173.patch
>
>
> LUCENE-5116 fixes addIndexes(Reader) to never write a 0-document segment (in
> the case you merge in empty or all-deleted stuff).
> I considered it just an inconsistency, but it could cause confusing
> exceptions to real users too if there was a "regression" here. (see solr
> users list:Split Shard Error - maxValue must be non-negative).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
