[ 
https://issues.apache.org/jira/browse/LUCENE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-5176:
--------------------------------

    Attachment: LUCENE-5176.patch

Here is the start to the patch.

I tried to do it cleaner in QueryUtils.

I dont understand why some tests like TestCachingWrapperFilter were using this.

I changed DiskFull and TestMultiFields to use the pkg-private setter on IW, but 
i dont know if their use is legitimate either.
                
> remove _TestUtil.keepFullyDeletedSegments
> -----------------------------------------
>
>                 Key: LUCENE-5176
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5176
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5176.patch
>
>
> The few tests that need to test something here can use the index-writer 
> pkg-private method.
> Other tests (like QueryUtils) can use a FilterAtomicReader to do their crazy 
> tests.
> Otherwise, we risk lots of stupid false test failures.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to