[ 
https://issues.apache.org/jira/browse/SOLR-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743841#comment-13743841
 ] 

Steve Rowe commented on SOLR-5173:
----------------------------------

Actually, I was wrong about the binary distribution containing Jetty 6 license 
files - it contains the .jar.sha1 files for Jetty 6, but not the license files.

In fact, there is a whole bunch of .sha1 files included in the binary 
distribution that don't need to be there:

solr-4.4.0/licenses/activation-1.1.jar.sha1
solr-4.4.0/licenses/AlchemyAPIAnnotator-2.3.1.jar.sha1
solr-4.4.0/licenses/ant-1.8.2.jar.sha1
solr-4.4.0/licenses/apache-mime4j-core-0.7.2.jar.sha1
solr-4.4.0/licenses/apache-mime4j-dom-0.7.2.jar.sha1
solr-4.4.0/licenses/attributes-binder-1.0.1.jar.sha1
solr-4.4.0/licenses/bcmail-jdk15-1.45.jar.sha1
solr-4.4.0/licenses/bcprov-jdk15-1.45.jar.sha1
solr-4.4.0/licenses/boilerpipe-1.1.0.jar.sha1
solr-4.4.0/licenses/carrot2-mini-3.6.2.jar.sha1
solr-4.4.0/licenses/cglib-nodep-2.2.jar.sha1
solr-4.4.0/licenses/commons-beanutils-1.7.0.jar.sha1
solr-4.4.0/licenses/commons-cli-1.2.jar.sha1
solr-4.4.0/licenses/commons-codec-1.7.jar.sha1
solr-4.4.0/licenses/commons-collections-3.2.1.jar.sha1
solr-4.4.0/licenses/commons-compress-1.4.1.jar.sha1
solr-4.4.0/licenses/commons-configuration-1.6.jar.sha1
solr-4.4.0/licenses/commons-digester-2.0.jar.sha1
solr-4.4.0/licenses/commons-fileupload-1.2.1.jar.sha1
solr-4.4.0/licenses/commons-io-2.1.jar.sha1
solr-4.4.0/licenses/commons-lang-2.6.jar.sha1
solr-4.4.0/licenses/concurrentlinkedhashmap-lru-1.2.jar.sha1
solr-4.4.0/licenses/derby-10.9.1.0.jar.sha1
solr-4.4.0/licenses/dom4j-1.6.1.jar.sha1
solr-4.4.0/licenses/easymock-3.0.jar.sha1
solr-4.4.0/licenses/fontbox-1.8.1.jar.sha1
solr-4.4.0/licenses/guava-14.0.1.jar.sha1
solr-4.4.0/licenses/hadoop-annotations-2.0.5-alpha.jar.sha1
solr-4.4.0/licenses/hadoop-auth-2.0.5-alpha.jar.sha1
solr-4.4.0/licenses/hadoop-common-2.0.5-alpha.jar.sha1
solr-4.4.0/licenses/hadoop-common-2.0.5-alpha-tests.jar.sha1
solr-4.4.0/licenses/hadoop-hdfs-2.0.5-alpha.jar.sha1
solr-4.4.0/licenses/hadoop-hdfs-2.0.5-alpha-tests.jar.sha1
solr-4.4.0/licenses/hppc-0.4.1.jar.sha1
solr-4.4.0/licenses/hsqldb-1.8.0.10.jar.sha1
solr-4.4.0/licenses/httpclient-4.2.3.jar.sha1
solr-4.4.0/licenses/httpcore-4.2.2.jar.sha1
solr-4.4.0/licenses/httpmime-4.2.3.jar.sha1
solr-4.4.0/licenses/icu4j-49.1.jar.sha1
solr-4.4.0/licenses/isoparser-1.0-RC-1.jar.sha1
solr-4.4.0/licenses/jackson-core-asl-1.7.4.jar.sha1
solr-4.4.0/licenses/jackson-mapper-asl-1.7.4.jar.sha1
solr-4.4.0/licenses/javax.servlet-api-3.0.1.jar.sha1
solr-4.4.0/licenses/jcl-over-slf4j-1.6.6.jar.sha1
solr-4.4.0/licenses/jdom-1.0.jar.sha1
solr-4.4.0/licenses/jempbox-1.8.1.jar.sha1
solr-4.4.0/licenses/jersey-core-1.16.jar.sha1
solr-4.4.0/licenses/jetty-6.1.26.jar.sha1
solr-4.4.0/licenses/jetty-continuation-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-deploy-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-http-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-io-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-jmx-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-security-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-server-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-servlet-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-util-6.1.26.jar.sha1
solr-4.4.0/licenses/jetty-util-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-webapp-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/jetty-xml-8.1.10.v20130312.jar.sha1
solr-4.4.0/licenses/joda-time-2.2.jar.sha1
solr-4.4.0/licenses/jsonic-1.2.7.jar.sha1
solr-4.4.0/licenses/jul-to-slf4j-1.6.6.jar.sha1
solr-4.4.0/licenses/junit-4.10.jar.sha1
solr-4.4.0/licenses/junit4-ant-2.0.10.jar.sha1
solr-4.4.0/licenses/juniversalchardet-1.0.3.jar.sha1
solr-4.4.0/licenses/langdetect-1.1-20120112.jar.sha1
solr-4.4.0/licenses/log4j-1.2.16.jar.sha1
solr-4.4.0/licenses/mahout-collections-1.0.jar.sha1
solr-4.4.0/licenses/mahout-math-0.6.jar.sha1
solr-4.4.0/licenses/mail-1.4.1.jar.sha1
solr-4.4.0/licenses/metadata-extractor-2.6.2.jar.sha1
solr-4.4.0/licenses/morfologik-fsa-1.5.5.jar.sha1
solr-4.4.0/licenses/morfologik-polish-1.5.5.jar.sha1
solr-4.4.0/licenses/morfologik-stemming-1.5.5.jar.sha1
solr-4.4.0/licenses/netcdf-4.2-min.jar.sha1
solr-4.4.0/licenses/noggit-0.5.jar.sha1
solr-4.4.0/licenses/objenesis-1.2.jar.sha1
solr-4.4.0/licenses/OpenCalaisAnnotator-2.3.1.jar.sha1
solr-4.4.0/licenses/org.restlet.ext.servlet-2.1.1.jar.sha1
solr-4.4.0/licenses/org.restlet-2.1.1.jar.sha1
solr-4.4.0/licenses/pdfbox-1.8.1.jar.sha1
solr-4.4.0/licenses/poi-3.9.jar.sha1
solr-4.4.0/licenses/poi-ooxml-3.9.jar.sha1
solr-4.4.0/licenses/poi-ooxml-schemas-3.9.jar.sha1
solr-4.4.0/licenses/poi-scratchpad-3.9.jar.sha1
solr-4.4.0/licenses/protobuf-java-2.4.0a.jar.sha1
solr-4.4.0/licenses/randomizedtesting-runner-2.0.10.jar.sha1
solr-4.4.0/licenses/rome-0.9.jar.sha1
solr-4.4.0/licenses/servlet-api-3.0.jar.sha1
solr-4.4.0/licenses/simple-xml-2.6.4.jar.sha1
solr-4.4.0/licenses/slf4j-api-1.6.6.jar.sha1
solr-4.4.0/licenses/slf4j-log4j12-1.6.6.jar.sha1
solr-4.4.0/licenses/spatial4j-0.3.jar.sha1
solr-4.4.0/licenses/start.jar.sha1
solr-4.4.0/licenses/Tagger-2.3.1.jar.sha1
solr-4.4.0/licenses/tagsoup-1.2.1.jar.sha1
solr-4.4.0/licenses/tika-core-1.4.jar.sha1
solr-4.4.0/licenses/tika-parsers-1.4.jar.sha1
solr-4.4.0/licenses/uimaj-core-2.3.1.jar.sha1
solr-4.4.0/licenses/velocity-1.7.jar.sha1
solr-4.4.0/licenses/velocity-tools-2.0.jar.sha1
solr-4.4.0/licenses/vorbis-java-core-0.1.jar.sha1
solr-4.4.0/licenses/vorbis-java-tika-0.1.jar.sha1
solr-4.4.0/licenses/WhitespaceTokenizer-2.3.1.jar.sha1
solr-4.4.0/licenses/wstx-asl-3.2.7.jar.sha1
solr-4.4.0/licenses/xercesImpl-2.9.1.jar.sha1
solr-4.4.0/licenses/xmlbeans-2.3.0.jar.sha1
solr-4.4.0/licenses/xz-1.0.jar.sha1
solr-4.4.0/licenses/zookeeper-3.4.5.jar.sha1

                
> Test-only Hadoop dependencies are included in release artifacts
> ---------------------------------------------------------------
>
>                 Key: SOLR-5173
>                 URL: https://issues.apache.org/jira/browse/SOLR-5173
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.4
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>            Priority: Blocker
>             Fix For: 4.5
>
>
> Chris Collins [reported on 
> solr-user|http://markmail.org/message/evhpcougs5ppafjk] that solr-core 4.4 
> has dependencies on hadoop, and indirectly on jetty 6.
> As a workaround for Maven dependencies, the hadoop-hdfs, hadoop-auth, and 
> hadoop-annotations dependencies can be excluded, which will also exclude the 
> indirect jetty 6 dependency/ies.  hadoop-common is a compile-time dependency, 
> though, so I'm not sure if it's safe to exclude.
> The problems, as far as I can tell, are:
> 1) The ivy configuration puts three test-only dependencies (hadoop-hdfs, 
> hadoo-auth, and hadoop-annotations) in solr/core/lib/, rather than where they 
> belong, in solr/core/test-lib/.  (hadoop-common is required for solr-core 
> compilation to succeed.)
> 2) The Maven configuration makes the equivalent mistake in marking these 
> test-only hadoop dependencies as compile-scope rather than test-scope 
> dependencies.
> 3) The Solr .war, which packages everything under solr/core/lib/, includes 
> these three test-only hadoop dependencies (though it does not include any 
> jetty 6 jars).
> 4) The license files for jetty and jetty-util v6.1.26, but not the jar files 
> corresponding to them, are included in the Solr distribution.
> I have working (tests pass) local Ant and Maven configurations that treat the 
> three hadoop test-only dependencies properly; as result, the .war will no 
> longer contain them - this will cover problems #1-3 above.
> I think we can just remove the jetty and jetty-util 6.1.26 license files from 
> solr/licenses/, since we don't ship those jars.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to