[ 
https://issues.apache.org/jira/browse/LUCENE-5185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747006#comment-13747006
 ] 

Robert Muir commented on LUCENE-5185:
-------------------------------------

{quote}
Maybe the smoke tester could be modified to directly test the checksums against 
the binary artifacts' 3rd party jars?
{quote}

+1

{quote}
My thinking here is that we should keep our distributions lean, including only 
the things that must be there, and I don't think these checksum files qualify.
{quote}

Under this line of thinking: then we shouldnt do a binary release at all. But 
if we are going to do one, one thats filled with over 100 third party 
dependencies, then I think some "paperwork" to go along with those is totally 
appropriate. 
                
> licenses/*.jar.sha1 don't belong in Lucene and Solr binary distributions
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-5185
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5185
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>            Priority: Minor
>             Fix For: 5.0, 4.5
>
>
> On LUCENE-3945, where external dependency checksum verification was put in 
> place, [[email protected]] wrote:
> bq. So i propose that we include checksum files in svn and in our source 
> releases that can be used by users to verify that the jars they get from ivy 
> match the jars we tested against.
> That is, checksum files in *binary* distributions was not part of the 
> proposal.
> And [in his comment associated with the final 
> patch|https://issues.apache.org/jira/browse/LUCENE-3945?focusedCommentId=13246476&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13246476]:
> bq. 2) fixes the binary releases to exlcude the sha1 files
> Somewhere between then and now, {{\*.jar.sha1}} files snuck back into the 
> Lucene and Solr binary releases, under the {{licenses/}} directory.  They 
> should not be there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to