OK, got a clean 'ant test'. So I think this is good to go. Big thanks Yonik! Every time I get back into multithreading stuff after not doing it for a while I have to relearn stuff it seems.
I'm not entirely enthused about the new c'tor for UnInvertedField, but it's private so at least it's an implementation detail that others won't be tempted to use. On Thu, Sep 5, 2013 at 1:04 PM, Erick Erickson (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/SOLR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Erick Erickson updated SOLR-2548: > --------------------------------- > > Attachment: SOLR-2548.patch > > bq: See FieldCacheImpl.get() - there is a CreationPlaceHolder object used. > > Right, but the map that that's placed _in_ is a map<key, Object>. The > UnInvertedField cache is map<key, UnInvertedField>. That's what was behind > my question about making a dummy UnInvertedField to use similarly to how > CreationPlaceHolder is used. I'm really not up for making the underlying > UnInvertedField cache take an Object, seems like the tail wagging the dog. > > Interestingly I think it was what [[email protected]] pointed out about > synching on different objects than I thought I was that was the problem > with TestDistributedGrouping, it passes now. > > The attached patch implements creating a placeholder UnInvertedField, > removes the pending map and passes the failing test from yesterday as well > as precommit. > > I'll run the full suite soon. If that passes, I'll let it stew for a bit > and commit tomorrow unless there are objections. > > > Multithreaded faceting > > ---------------------- > > > > Key: SOLR-2548 > > URL: https://issues.apache.org/jira/browse/SOLR-2548 > > Project: Solr > > Issue Type: Improvement > > Components: search > > Affects Versions: 3.1 > > Reporter: Janne Majaranta > > Assignee: Erick Erickson > > Priority: Minor > > Labels: facet > > Attachments: SOLR-2548_4.2.1.patch, SOLR-2548_for_31x.patch, > SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, > SOLR-2548.patch > > > > > > Add multithreading support for faceting. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
