[ https://issues.apache.org/jira/browse/SOLR-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762988#comment-13762988 ]
Simon Endele commented on SOLR-5020: ------------------------------------ It looks like this isn't working in combination with grouping. Is that possible? I applied the attached patch to my Solr 4.4.0 workspace containing an AclQParserPlugin as described here: http://searchhub.org/2012/02/22/custom-security-filtering-in-solr/ It works without grouping, but if grouping is activated, the collect() method is still called, but finish() is not. > Add finish() method to DelegatingCollector > ------------------------------------------ > > Key: SOLR-5020 > URL: https://issues.apache.org/jira/browse/SOLR-5020 > Project: Solr > Issue Type: New Feature > Components: search > Affects Versions: 5.0 > Reporter: Joel Bernstein > Priority: Minor > Fix For: 4.5, 5.0 > > Attachments: SOLR-5020.patch > > > This issue adds a finish() method to the DelegatingCollector class so that it > can be notified when collection is complete. > The current collect() method assumes that the delegating collector will > either forward on the document or not with each call. The finish() method > will allow DelegatingCollectors to have more sophisticated behavior. > For example a Field Collapsing delegating collector could collapse the > documents as the collect() method is being called. Then when the finish() > method is called it could pass the collapsed documents to the delegate > collectors. > This would allow grouping to be implemented within the PostFilter framework. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org