[
https://issues.apache.org/jira/browse/SOLR-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763018#comment-13763018
]
ludovic Boutros edited comment on SOLR-5224 at 9/10/13 1:18 PM:
----------------------------------------------------------------
This little patch for 4.4 works.
I checked the current unit test in order to add some tests, but it's not
trivial (at least for me :)).
was (Author: lboutros):
This little patch is working.
I checked the current unit test in order to add some tests, but it's not
trivial (at least for me :)).
> SolrCmdDistributor flush functions should combine original request params
> -------------------------------------------------------------------------
>
> Key: SOLR-5224
> URL: https://issues.apache.org/jira/browse/SOLR-5224
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.3.1, 4.4
> Reporter: ludovic Boutros
> Assignee: Mark Miller
> Fix For: 4.5, 5.0
>
> Attachments: SOLR-5224.patch
>
>
> The flush commands in the class SolrCmdDistributor do not combine original
> request params into external update requests.
> The actual code is :
> {code:title=SolrCmdDistributor.java|borderStyle=solid}
> UpdateRequestExt ureq = new UpdateRequestExt();
>
> ModifiableSolrParams combinedParams = new ModifiableSolrParams();
>
> for (AddRequest aReq : alist) {
> AddUpdateCommand cmd = aReq.cmd;
> combinedParams.add(aReq.params);
>
> ureq.add(cmd.solrDoc, cmd.commitWithin, cmd.overwrite);
> }
>
> if (ureq.getParams() == null) ureq.setParams(new
> ModifiableSolrParams());
> ureq.getParams().add(combinedParams);
> {code}
> but, the params from the original request: cmd.getReq().getParams() should be
> combined as well in order to get them back in custom update processors for
> instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
