[ 
https://issues.apache.org/jira/browse/SOLR-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764412#comment-13764412
 ] 

Joel Bernstein commented on SOLR-5230:
--------------------------------------

This is the way it likely has to be. Both of the grouping phases need to call 
the postFilter to return the proper results. And if the postFilter is called, 
the finish() needs to be called.

For expensive postFilters, this is not ideal. But, that's the implementation.

Take a look at SOLR-5027 which was the original reason why the finish() method 
was added to DelegatingCollector. This an alternative to field collapsing and 
grouping which performs much better then ngroups and group.truncate combined.

SOLR-5027 will be getting a lot of my attention this month so any feedback you 
have on this would be appreciated.


                
> Call DelegatingCollector.finish() during grouping
> -------------------------------------------------
>
>                 Key: SOLR-5230
>                 URL: https://issues.apache.org/jira/browse/SOLR-5230
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 4.4
>            Reporter: Joel Bernstein
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-5230.patch
>
>
> This is an add-on to SOLR-5020 to call the new DelegatingCollector.finish() 
> method from inside the grouping flow. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to