[ https://issues.apache.org/jira/browse/LUCENE-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764908#comment-13764908 ]
Robert Muir commented on LUCENE-5204: ------------------------------------- Can we make FilterDirectory package-private? I know we have done this FilterXXX strategy with other apis, but delegating over an abstract class is always broken by definition... Its a little scary to expose this as a "supported API" for directory. > Make Directory easier to wrap > ----------------------------- > > Key: LUCENE-5204 > URL: https://issues.apache.org/jira/browse/LUCENE-5204 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Attachments: LUCENE-5204.patch > > > We have a few DirectoryWrapper implementations such as > RateLimitedDirectoryWrapper and MockDirectoryWrapper. However, the Directory > class is not straightforward to wrap since it already has logic for getting > and setting the lock factory, so wrappers need to decide whether they should > forward lock handling to the delegate or handle it themselves. > I would like to move the locking logic out of the Directory class and to have > a base {{FilterDirectory}} that could be extended by other directory wrapper > impls. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org