[
https://issues.apache.org/jira/browse/LUCENE-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770368#comment-13770368
]
Uwe Schindler commented on LUCENE-5223:
---------------------------------------
Hi Hoss,
thanks for the patch. You can assign the issue to yourself. I just took it,
because I wrote the code originally, so I wanted find out what changed.
In that case the change to Luecen 3 was, that IndexWriterConfig no longer
allows {{null}} as InfoStream, but instead requires NO_OUTPUT constant (which
is a good thing). While doing this change, the code in IndexUpgrader was
unfortunately not upgraded. Your new tests are fine. The random directory is OK.
I don't think that we should allow {{null} in IndexWriterConfig. I don't like
this behaviour in Solr (e.g., SolrResourceLoader and a lot of other classes) to
use crazy defaults if somewhere {{null}} is passed. Always be explicit.
The problem is a missing @NotNull annotation, like Java 8 provides (does it?).
> IndexUpgrader (4.4.0) fails when -verbose is not set, or when any value of
> -dir-impl is specified
> -------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5223
> URL: https://issues.apache.org/jira/browse/LUCENE-5223
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.4
> Environment: Linux
> Reporter: Bruce Karsh
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: LUCENE-5223.patch
>
>
> Here it fails because -verbose is not set:
> $ java -cp ./lucene-core-4.4-SNAPSHOT.jar
> org.apache.lucene.index.IndexUpgrader ./INDEX
> Exception in thread "main" java.lang.IllegalArgumentException: printStream
> must not be null
> at
> org.apache.lucene.index.IndexWriterConfig.setInfoStream(IndexWriterConfig.java:514)
> at org.apache.lucene.index.IndexUpgrader.<init>(IndexUpgrader.java:126)
> at org.apache.lucene.index.IndexUpgrader.main(IndexUpgrader.java:109)
> Here it works with -verbose set:
> $ java -cp ./lucene-core-4.4-SNAPSHOT.jar
> org.apache.lucene.index.IndexUpgrader -verbose ./INDEX
> IFD 0 [Mon Sep 16 18:25:53 PDT 2013; main]: init: current segments file is
> "segments_5";
> deletionPolicy=org.apache.lucene.index.KeepOnlyLastCommitDeletionPolicy@42698403
> ...
> IW 0 [Mon Sep 16 18:25:53 PDT 2013; main]: at close: _2(4.4):C4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
