[ 
https://issues.apache.org/jira/browse/LUCENE-5240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776230#comment-13776230
 ] 

Michael McCandless commented on LUCENE-5240:
--------------------------------------------

+1, this is great.  Fun to see all the tests that were violating the TS API ...
                
> additional safety in Tokenizer state machine
> --------------------------------------------
>
>                 Key: LUCENE-5240
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5240
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5240.patch
>
>
> {code}
>    * <b>NOTE:</b> 
>    * The default implementation closes the input Reader, so
>    * be sure to call <code>super.close()</code> when overriding this method.
>    */
>   @Override
>   public void close() throws IOException {
> {code}
> We can add a simple check for this easily now in setReader. I found a few 
> bugs, and fixed all except TrieTokenizer in solr (I am lost here... somewhere 
> i have a patch to remove this thing).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to