I attached a fix to the issue Shawn created for the missing implicit Solr-core-properties-on-RELOAD issue: SOLR-5279
IMHO, this regression should be fixed in 4.5. Adrien, I tried to raise you on IRC but didn't get a response - is it okay with you to do a respin? I'll commit to trunk and branch_4x with the CHANGES.txt entry under 4.6 until you say it's okay. Steve On Sep 26, 2013, at 7:36 PM, Shawn Heisey <[email protected]> wrote: > On 9/26/2013 1:26 PM, Adrien Grand wrote: >> Here is a new release candidate for which LUCENE-5218, LUCENE-5245 and >> LUCENE-5233 have been backported. Please vote to release the following >> artifacts: >> >> http://people.apache.org/~jpountz/staging_area/lucene-solr-4.5.0-RC4-rev1526586/ >> >> This vote is open until Tuesday. >> >> Smoke tester was happy on my end, so here is my +1. >> > > I just ran into a problem with the release candidate, let me know if you > think it's a release-stopper. I wasn't looking for anything wrong, I was > just putting the release candidate on my dev server. I noticed a cosmetic > issue, and while I was trying to track down that, I stumbled across something > bigger. This is not running with zookeeper. > > > Pieces of my solrconfig.xml file are shared (via symlinks and xinclude > directives) with many different cores. In the file for the indexConfig > section, I have this: > > <infoStream file="INFOSTREAM-${solr.core.name}.txt">false</infoStream> > > During startup, this doesn't cause any problem at all. On core reload, > however, I get a big exception and it can't initialize the core. The cause: > > Caused by: org.apache.solr.common.SolrException: No system property or > default value specified for solr.core.name > value:INFOSTREAM-${solr.core.name}.txt > at > org.apache.solr.util.PropertiesUtil.substituteProperty(PropertiesUtil.java:66) > at org.apache.solr.util.DOMUtil.substituteProperties(DOMUtil.java:298) > at org.apache.solr.util.DOMUtil.substituteProperties(DOMUtil.java:300) > at org.apache.solr.util.DOMUtil.substituteProperties(DOMUtil.java:300) > at org.apache.solr.core.Config.<init>(Config.java:141) > at org.apache.solr.core.Config.<init>(Config.java:86) > at org.apache.solr.core.SolrConfig.<init>(SolrConfig.java:129) > at org.apache.solr.core.SolrCore.reload(SolrCore.java:403) > at org.apache.solr.core.CoreContainer.reload(CoreContainer.java:681) > ... 31 more > > I've run into problems with the implicit properties before, but that was at > Solr startup. This is the first time in quite a while that I've tried a > RELOAD on my dev server, so I don't know how long this problem has existed. > > At one point, I had to use ${name} instead of ${solr.core.name} in branch_4x > versions, but that got fixed. If I need to use a different property going > forward, I'm OK with that. I know that Hoss was doing something recently > with implicit properties in the Reference Guide, but I haven't looked at it > closely. > > Thanks, > Shawn > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
