[
https://issues.apache.org/jira/browse/SOLR-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781190#comment-13781190
]
Steve Rowe commented on SOLR-5264:
----------------------------------
The idea seems good to me. All Solr tests pass for me on trunk with the patch
applied.
A few nits:
* removeAll and removeArgs don't look very different, but they do different
things. I think their javadocs should mention each other and say how they're
different from each other.
* I don't think removeArgs is a sufficiently descriptive name, but all attempts
I've made to come up with a better one are way too long, like
recursivelyRemoveAllStringArgs. But I think we could do better somehow here.
oneOrMany is short but doesn't mention that the args are removed, so I don't
think we should just use it.
* The deprecation message on oneOrMany should say which version it will be
removed in. I think 5.0 is a better choice than 4.7 or 4.8, since there is
already established precedent for deprecation in major version X, removal in
major version X+1. Then the trunk commit will remove it, and the branch_4x
version will have the deprecation message, and there is nothing else to do
(except a CHANGES.txt entry explaining this, which you should include when you
commit), so this strategy is also easier to implement than removal in X.Y+1 or
2, since you have to remember to do that then.
> New method on NamedList to return one or many config arguments as collection
> ----------------------------------------------------------------------------
>
> Key: SOLR-5264
> URL: https://issues.apache.org/jira/browse/SOLR-5264
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.5
> Reporter: Shawn Heisey
> Assignee: Shawn Heisey
> Priority: Minor
> Fix For: 5.0, 4.6
>
> Attachments: SOLR-5264.patch, SOLR-5264.patch, SOLR-5264.patch,
> SOLR-5264.patch
>
>
> In the FieldMutatingUpdateProcessorFactory is a method called "oneOrMany"
> that takes all of the entries in a NamedList and pulls them out into a
> Collection. I'd like to use that in a custom update processor I'm building.
> It seems as though this functionality would be right at home as part of
> NamedList itself. Here's a patch that moves the method.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
