[ 
https://issues.apache.org/jira/browse/LUCENE-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-5246:
-------------------------------

    Attachment: LUCENE-5246.patch

Patch fixes SIPC to only track the files that are used by the different 
generations, determined by fieldInfosGen. Also added 
testDeleteUnusedUpdatesFiles - it's kind of hacky as it asserts on _0_1.fnm, 
e.g. won't work if we'll ever have a Codec which writes FieldInfos to a 
custom-named files. If you have a better idea how to assert that the unused 
updates files were deleted, let me know and I'll change the test accordingly.

I also relaxed testStressMultithreading by allocating between 3-6 update 
threads as well as extracted the commit logic out to a separate thread. Also 
limited the number of updates to 20-100 (instead of atLeast(40) which could 
reach 200+ with certain test parameters).

> SegmentInfoPerCommit continues to list unneeded updatesFiles
> ------------------------------------------------------------
>
>                 Key: LUCENE-5246
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5246
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-5246.patch
>
>
> SegmentInfoPerCommit continues to list updates files even if they are 
> unneeded anymore. For example, if you update the values of documents of field 
> 'f', it creates a gen'd .fnm (FieldInfos) file. If you commit/reopen and 
> update the field again (maybe now a different set of documents), it creates 
> another gen'd .fnm, but continues to list both gens, even though only the 
> latest one is needed.
> To solve this, SIPC would need to know then dvGen of each FieldInfo, so that 
> it can correctly list only the updates files that are truly needed. I'll work 
> on a testcase and fix.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to